Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

dep: unexport Manifest.Ignored #594

Closed
wants to merge 1 commit into from
Closed

dep: unexport Manifest.Ignored #594

wants to merge 1 commit into from

Conversation

davecheney
Copy link
Contributor

Manifest.Ignored should be accessed via the IgnoredPackages() helper
which returns a copy of the field as a map.

Manifest.Ignored should be accessed via the IgnoredPackages() helper
which returns a copy of the field as a map.
@sdboyer
Copy link
Member

sdboyer commented May 17, 2017

Without a function that allows an external package to construct a Manifest with arbitrary values (including ones for this value), I think I'd prefer to leave these properties exported.

Also, rather than these individual PRs, can we have that discussion about an export policy (in an issue dedicated to it)? It seems clear you have some guiding principles you're operating by, and it would be good to make this explicit.

@davecheney
Copy link
Contributor Author

davecheney commented May 17, 2017 via email

@sdboyer
Copy link
Member

sdboyer commented May 17, 2017

That's an accurate functional statement, of course. But as a policy, it addresses only one of the relevant factors - minimizing surface area. On its own, we'd rapidly reach the point where we export nothing at all. The question that we need to answer is what we want the surface area to be, and how that relates to a release process.

I could certainly be convinced that the right position for now is to be conservative and export absolutely nothing publicly. But I want us to set a goal, even a loose one, and move towards it, rather than iterating without a plan.

@sdboyer
Copy link
Member

sdboyer commented Jun 15, 2017

Closing this - to the extent we've articulated a policy, it does include exporting Manifest.

@sdboyer sdboyer closed this Jun 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants